src/Controllers/index.js (1)

172-201: ⚠️ Potential issue | 🟠 Major

Only load the default push adapter when it is actually needed.

Line 191 unconditionally imports the optional default adapter even when push is unset or a custom push.adapter is provided. This can cause startup to fail unnecessarily when the adapter is not used. Additionally, the error detection at line 176 using message.includes('@parse/push-adapter') can misclassify transitive dependency failures from within @parse/push-adapter as a missing package if the error message path happens to contain that string.

Move the import into the conditional block that only executes when actually needed:

Suggested fix

 function isPushAdapterModuleMissing(error: any): boolean {
   const message = `${error?.message || error || ''}`;
   const hasMissingCode =
     error?.code === 'ERR_MODULE_NOT_FOUND' || error?.code === 'MODULE_NOT_FOUND';
-  return hasMissingCode && message.includes('@parse/push-adapter');
+  return (
+    hasMissingCode &&
+    /Cannot find (?:package|module) ['"]@parse\/push-adapter['"]/.test(message)
+  );
 }
 
   // Pass the push options too as it works with the default
   let ParsePushAdapter;
-  try {
-    ParsePushAdapter = await loadModule('@parse/push-adapter');
-  } catch (error) {
-    if (!isPushAdapterModuleMissing(error)) {
-      throw error;
-    }
-    if (push && !pushOptions.adapter) {
+  if (push && !pushOptions.adapter) {
+    try {
+      ParsePushAdapter = await loadModule('@parse/push-adapter');
+    } catch (error) {
+      if (!isPushAdapterModuleMissing(error)) {
+        throw error;
+      }
       throw new Error(
         'Push is configured but the optional dependency "@parse/push-adapter" is not installed. Install "@parse/push-adapter" or configure "push.adapter".'
       );
     }
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Controllers/index.js` around lines 172 - 201, The code currently calls
loadModule('@parse/push-adapter') unconditionally and uses
isPushAdapterModuleMissing(error) which naively checks
message.includes('@parse/push-adapter'), causing unnecessary startup failures
and false positives; update getPushController so ParsePushAdapter is only loaded
when push is truthy and pushOptions.adapter is not provided (i.e. move the await
loadModule('@parse/push-adapter') call inside the conditional that checks if
push && !pushOptions.adapter), and harden isPushAdapterModuleMissing(error) to
detect a missing package more precisely by checking error.code for
'ERR_MODULE_NOT_FOUND' or 'MODULE_NOT_FOUND' and matching the error message
against a stricter pattern that looks for "Cannot find module" (or the module
name quoted) specifically for '@parse/push-adapter' rather than a simple
substring match.